commit da94416dd48171d53a9fe3ac57763d7552987dca Author: Paul Jakma Date: Fri Mar 10 12:55:06 2017 +0000 release: Quagga 1.2.1 commit 431900f023137d8ffb4010314913a2ecadfcfa91 Author: Paul Jakma Date: Thu Mar 9 17:58:39 2017 +0000 buildbot: build documentation, add nightly upload of master docs, other tweaks * master.cfg: Add a "build-docs" builder to test generation of HTML and PDF docs into the commit checks. With nightly=true property, upload generated docs to a static dir on the master. Run from a NightlyScheduler. Add the properties from the internal worker config to the buildbot BuildSlave properties, so they're visible in the web UI. Filter through a workers2publicprops helper, to whitelist allowed props. commit 5e558004594497ea91dee123ff14e5e487275d73 Author: Paul Jakma Date: Thu Mar 9 00:56:32 2017 +0000 doc: Nearly all the world uses A4 paper, set as default for TeX output commit 6a48343cd6e392a3ae48dbb735008f911e60420d Author: Paul Jakma Date: Thu Mar 9 00:54:44 2017 +0000 doc: Clean the tex index files up commit 1bfd6551c9d1b9e3e0f2d04bbbc636ef33e4a2fd Author: Paul Jakma Date: Wed Mar 8 23:31:47 2017 +0000 doc: Fix overfull hboxes errors that cause PDF build to return fail * overfull hboxes cause texi2dvi to return fail, even if the PDf is written. We hacked around this by running it with '... || true', but that sucks for buildboting the docs. Fix all the overfull hboxes. * ospfd.texi: Long command definitions can cause hbox overruns in the columnar command definitions index. This leads to strange errors about "Missing number, treated as zero." when building the index - very hard to figure out. 'show ip ospf database ...' was the culprit. Use a distinct deffnx alias for each option instead of trying to stuff them into 1 line. commit 7ecc5f5f2c8d967670b0bf4bb4cd6d2684daa94a Author: Paul Jakma Date: Wed Mar 8 23:31:03 2017 +0000 doc: Remove refs to removed topology figures commit 3db7c8743a87c77f2e00254dd171b1eca4315a35 Author: Paul Jakma Date: Wed Mar 8 23:29:08 2017 +0000 doc: Explicit quagga.pdf rule can go now * Makefile.am: The Quagga specific PDF dependency is gone. The overfull boxes that caused texi2dvi to return fail code are gone. So the custom rule can go. commit 974511e28a30f478dbc38d782f2dc0dbf4bc7d04 Author: Paul Jakma Date: Wed Mar 8 22:01:37 2017 +0000 doc/routeserver: Remove needless figures, centre and tweak other figs * routeserver.texi: The full-mesh v RS topology diagrammes are fairly obvious and don't deserve so much space. As smaller wrap-floats they might be acceptable, but there seems no way to access that TeX feature from Texinfo. So nuke them. Centre the 2 other figures. Tweak size to avoid bbox overflow messages. commit dcfb4809158ade2b5070229297b95c944660cdf2 Author: Paul Jakma Date: Wed Mar 8 21:58:30 2017 +0000 doc: Tweak internal layout of fig-rs-processing slightly commit 69c62987e47a8c6c852b3bf90bc5e48f8b70ee5f Author: Paul Jakma Date: Wed Mar 8 21:54:09 2017 +0000 doc: pdftex works with PNGs now, remove dependency on PDF figures * Makefile.am: pdftex seems to work fine with PNGs now. So the need to build PDF versions of the figures using ImageMagick convert is gone. Remove the dependency. Can leave the rule for now, no benefit removing it. commit 69f8d5df72b6bd9c39c3a262ae0ed07f2cd566e9 Author: Paul Jakma Date: Wed Mar 8 17:15:58 2017 +0000 configure: Add commonly used GCC security flags commit ca7399f165f892620cbabdeb2b62cf792a6fc9d6 Author: Paul Jakma Date: Wed Mar 8 17:15:00 2017 +0000 doc: Add a nice CSS file for HTML texinfo commit 72e3b8b8d222e43bf74d4a9cd4cba63aa4d83fb5 Author: Paul Jakma Date: Wed Mar 8 10:27:54 2017 +0000 buildbot: Add revlink to map quagga git repo to Savannah cgit URI commit e28ebbccc870110f0309d93b87c1574c399f2b3b Author: Paul Jakma Date: Tue Mar 7 15:25:44 2017 +0000 solaris/buildbot: Add SMF service manifest for buildbot-slave/worker commit 203ab894a8cfc2107179d2d52bac9d16ed7dd8da Author: Paul Jakma Date: Tue Mar 7 14:54:28 2017 +0000 buildbot: add OpenIndiana hipster bot commit e17ff9be4efb9d013ffa86a460a35ec03ca8d178 Author: Paul Jakma Date: Tue Mar 7 14:38:48 2017 +0000 HACKING: git diff ... | buildbot try example commit 32947f26f944e1a3ea28f935820dbc6c54181e2c Author: Paul Jakma Date: Tue Mar 7 14:35:29 2017 +0000 configure: use AC_C_FLAG for Sun Studio cc commit f25b7317d77789221e3346b99c459c68e51c742d Author: Paul Jakma Date: Tue Mar 7 10:36:14 2017 +0000 configure: libtool < 2.4.6 doesn't work with fstack-protector-strong * configure.ac: GCC -fstack-protector-strong gives undefined symbol error when linking on __stack_chk_fail_local with libtool < 2.4.6. The gcc arg is not passed on when linking. OpenIndiana hipster has 2.4.2 at the moment. Test the libtool version and drop the arg and warn the user. commit d04f9ec9a6f3df61fc2f0cab2afd552567f83191 Author: Jakub Zawadzki Date: Sat Mar 4 20:41:02 2017 +0100 doc: make netmasks in 4.3 Static Route Commands the same In 4.3 documentation shows example for defining static routes: -------------------------------------------------------------- ip route 10.0.0.0/8 10.0.0.2 (...) ip route 10.0.0.0 255.255.255.0 10.0.0.2 (...) These statements are equivalent to those in the previous example. -------------------------------------------------------------- 10.0.0.0/8 is not equivalent to 10.0.0.0/255.255.255.0, fix it. should fix #811 after html regenerating. commit 55b11c2e01d0761064863247df9c4af943cd304e Author: Jakub Zawadzki Date: Sat Mar 4 19:43:46 2017 +0100 vtysh: Bug 789 - vtysh ripngd does not have distribute-list command Make commands added by distribute_list_init() from ripd/ripngd daemon known to vtysh. Babeld leftovers not included, also other commands (show, write) from bug #789 not included. commit 0d91779a1fd7f90bf13ebfb792dc4e4fcfc57bba Author: Paul Jakma Date: Sun Mar 5 14:53:59 2017 +0000 infra/buildbot: fix "for w workers", use common defs for common sets commit 390bffa452d4c9525587dbc8a7a19a9b096c11fa Author: Paul Jakma Date: Sun Mar 5 14:27:11 2017 +0000 infra/buildbot: Add initial RPM check builders * master.cfg: Add an initial RPM rpm check builders, to run rpmlint and rpmbuild tests on builders with "pkg" == "rpm". some issues in buildbot (least on F24): - RpmLint doesn't get imported, have to run manually. - RpmBuild always sets 'dist', it shouldn't really. urg. - RpmBuild 'rpmdir' argument doesn't get Interpolated, so can't put the built RPMs cleanly into a distinct directory. When fixed, can auto-publish RPMs. For now, just check. commit 3bc12739fdaccfcf73cafa51c98046e58529fe80 Author: Paul Jakma Date: Sun Mar 5 13:33:25 2017 +0000 distro/redhat: Allow for split info files commit 304ec31598895c8c6da7a9fa9b9ba1f7217cced0 Author: Paul Jakma Date: Sun Mar 5 12:39:41 2017 +0000 distro/redhat: Make texi2html conditional, default off, to avoid TeX deps commit 75ebcd86b1abd5db97b91a2cff1df6ba444cca7c Author: Paul Jakma Date: Sun Mar 5 10:21:02 2017 +0000 distro/redhat: fix rpmlint warnings * quagga.spec.in: Use %global when defining globals inside conditional blocks. Comment Obsoletes as rpmlint wants specific versions. The packages are long gone, but leave as historical documentation. Don't use %version in changelog entries, or other live macros. Fix spaces-for-indent everywhere, use tab (sorry spaces people). commit 7e43fe44ba1a7da4bd8520625ab5f66867fce761 Author: Paul Jakma Date: Sat Mar 4 15:09:41 2017 +0000 infra/patchwork: systemd files and production.py settings * systemd/patchwork-delivery*: on demand socket to take mail in a localhost TCP socket, to allow patchwork to be in a separate container from email. * production.py: patchwork.settings.production file. * pass.py: example pass.py file commit 08815d59c369ee2698d304d91e22e6eddcce31ae Author: Paul Jakma Date: Sat Mar 4 14:30:44 2017 +0000 infra: buildbot master configs and slave systemd service file * master: master.cfg and example pass.cfg file * worker: systemd service unit file. Setting up a slave/worker is trivial: su - buildbot buildslave create-slave . radia.quagga.net buildbot- commit d77ad3cff1d3d32bce7b49dbefebda7c10f1592e Author: Paul Jakma Date: Sat Mar 4 00:10:30 2017 +0000 HACKING: fix indentation in URLs list, remove super obsolete import section commit 32b4fb45f577cce2ab354c4914a2af845ebfc4e4 Author: Paul Jakma Date: Sat Mar 4 00:08:19 2017 +0000 HACKING: example config for buildbot client and usage for 'try' command commit db2dafa63bd527fc9ef49c1997f385c79294e65a Author: Paul Jakma Date: Fri Mar 3 18:08:03 2017 +0000 build: Fix distcheck errors * doc/Makefile.am: Clean up the info files. Ignore errors with DVI building, who cares. * tests/Makefile.am: cleanup stuff to fix distcleancheck commit db968b6d3277794f2a615a5292c33eec2b9e26e3 Author: Paul Jakma Date: Sat Mar 4 00:11:57 2017 +0000 doc: stop generating defines.texi from configure * generating defines.texi from configure means quagga.info will always have to be rebuilt by end-users, even from dist tarballs. Also breaks distcheck assumptions that info won't need to be built - which can be fixed with 'info-in-builddir' automake option, but that's too recent to rely on. * doc/defines.texi.in: nuke * doc/defines.texi: Add static version. * {doc/Makefile.am,configure}: nuke autogen of above * doc/quagga.texi: remove the 1 use of PACKAGE_STRING commit 45c5426ac96a2ef815a9c21396678e1710ac4e52 Author: Paul Jakma Date: Fri Mar 3 15:06:48 2017 +0000 hacking: Add link to buildbot commit 4cdc030c8a37d4985dc1b9b7b1f5bf0d3bf52be7 Author: Paul Jakma Date: Fri Mar 3 15:07:28 2017 +0000 distro/redhat: build needs pkg-config and nhrpd needs c-ares commit 9368746527c6d5c8f55343237326456b2c20a41d Author: Paul Jakma Date: Mon Feb 27 22:42:59 2017 +0000 distro/redhat: Update to F24 and fix few issues, add nhrpd.service * redhat/quagga.spec.in: Review Fedora spec file and sync up with any useful differences, inc: - Add tmpfiles.d/quagga.conf config for Quagga from Fedora - Add quagga-filter-perl-requires.sh from Fedora. - Move libs to %{_libdir}/quagga as per Fedora - use systemd_postun_with_restart for postun Add nhrpd.service systemd file. Simplify/chop down the RPM description. * Makefile.am: Update to match commit 9e31fbc996a58047e490333df1f7bf1c809a1488 Author: Paul Jakma Date: Mon Feb 27 17:43:44 2017 +0000 distro/redhat: spec syntax error if texi2html not installed * redhat/quagga.spec.in: If texi2html is not installed you get a confusing error about a syntax issue in an %if statement, far from the problem. Fix. commit 64c56085661d7e4f41dc59bbf62643e682ce51c2 Author: Michal Sekletar Date: Thu Oct 20 12:56:34 2016 +0200 systemd: various service file improvements (1) network.target is generally used as a synchronization point during boot up and not as a "boot target" (target where services are actually enabled). Also as per 'man 7 systemd.special', service implementing networking should pull network.target into transaction and order itself before it. Hence, it doesn't make sense for zebra and friends to be enabled in network.target, because they should actively pull in network.target into boot transaction. Let's enable them as normal services in multi-user.target and order against network{,-pre}.target appropriately. (2) All quagga daemons needs zebra to be running at all times and want to restarted/stopped whenever zebra is. This is expressed by BindsTo= dependency in a unit file (note "s" in Binds). commit 2d78fe7e35344ad9340fa7e36c704a8c5c2485c8 Author: Timo Teräs Date: Tue Feb 14 13:07:39 2017 +0200 distro/redhat: package nhrpd commit 004db27ada7b37adf84408dbb98a3d92e4e4d6c0 Author: Timo Teräs Date: Tue Feb 14 11:55:09 2017 +0200 nhrpd: workaround old kernel vs. glibc definition conflics fixes #908 With kernel-headers-3.10.0 we have: In file included from netlink_gre.c:15:0: /usr/include/linux/ipv6.h:19:8: error: redefinition of 'struct in6_pktinfo' struct in6_pktinfo { ^ In file included from netlink_gre.c:10:0: /usr/include/netinet/in.h:536:8: note: originally defined here struct in6_pktinfo ^ In file included from netlink_gre.c:15:0: /usr/include/linux/ipv6.h:24:8: error: redefinition of 'struct ip6_mtuinfo' struct ip6_mtuinfo { ^ In file included from netlink_gre.c:10:0: /usr/include/netinet/in.h:543:8: note: originally defined here struct ip6_mtuinfo So instead of libc's netinet/in.h include kernel's linux/in.h and the add sys/socket.h for struct sockaddr since it does not seem to be defined in kernel headers. commit 343074aacfe9ec8d00e2c123f14f418a0920585b Author: Brian Utterback Date: Thu Feb 23 13:31:38 2017 +0000 solaris: Fix quagga.init.in shell errors * quagga.init.in: SMF_GROUP assignment shell is missing a space, so never works. Test for DAEMON_PATH and DAEMON being empty never works, fix. Test for configuration file should use the SMF property, not the default - the default config file location is already set in the quagga.xml file that sets the SMF property defauls. See bugs #877, #878, and #879. [ commit message by Paul Jakma / ] commit 2e0fb0e1eee44e94021fd0b6a5c46bd7f915a7f0 Author: Timo Schöler Date: Thu Feb 23 13:16:42 2017 +0000 redhat: Add quagga user to quaggavt vty group by default, bug #937 * See bugzilla #937 commit e7c65f6f1a951dd94f1c2e327d968bb8d468d0b5 Author: Denis Ovsienko Date: Mon Feb 20 00:54:05 2012 +0400 ospfd: address ospf_schedule_abr_task() warning commit 21e8b42dccdf7da3bbb3e057edd5c44da446d729 Author: Svata Dedic Date: Thu Dec 22 18:07:15 2011 +0400 ospfd: fix NSSA LSA translation (BZ#493) * See bugzilla #439 commit 6dbb58c04078c31ca3f43e9754b498aa3be6518b Author: Paul Jakma Date: Wed Feb 8 15:05:06 2017 +0000 zebra: Make the --nl-bufsize arg set the input parse buffer too * See bug #887. Existing statically sized NL_PKT_BUF_SIZE input parse buffer in netlink_parse_info may not be enough. As an initial hacky fix, at least give admins a runtime way to change this buffer, with the existing --nl-bufsize argument to zebra. * rt_netlink.c: (nl_rcvbuf) static input buffer and length. (netlink_parse_info) replace the local fixed size buffer with nl_rcvbuf. Improve warning on MSG_TRUNC to advise admin on what to do. (kernel_init) Dynamically allocate nl_rcvbuf input parse buffer to at least 2 pages, or nl_rcvbufsize argument, whichever is greater. Based on the debugging and investigation of: Konstantin